Add CI job for lightspeed operator deployment - #65
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: malingatembo The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: Comment |
|
/recheck |
|
Build failed (check pipeline). Post Warning: |
|
/recheck |
|
recheck |
1 similar comment
|
recheck |
Creates lightspeed-operator-deployment-crc job that: - Deploys operator using ci-framework playbook - Uses example LLM endpoint (no real credentials) - Expected to fail on auth verification - Inherits from cifmw-base-crc for CRC cluster provisioning JIRA: OSPRH-33344
0c3b371 to
cecc1eb
Compare
creates lightspeed-operator-deployment-crc job that: - deploys operator using ci-framework playbook - expected to fail on auth verification ( uses fake creds for LLM endpoints ) - matches file pattern in openstack-operator (in zuul.d/) Jira: OSPRH-33344
|
Unable to freeze job graph: Job lightspeed-operator-deployment-crc does not specify a run playbook |
Created ci/playbooks/lightspeed/run.yml to execute deployment hook Added run: directive to lightspeed-operator-deployment-crc job Fixes Zuul CONFIG_ERROR: "job does not specify a run playbook" Related: OSPRH-33344
|
Build failed (check pipeline). Post ❌ lightspeed-operator-deployment-crc FAILURE in 29m 14s |
| # CI job for deploying OpenStack Lightspeed operator | ||
| - job: | ||
| name: lightspeed-operator-deployment-crc | ||
| parent: cifmw-base-crc |
There was a problem hiding this comment.
question (non-blocking): Does this job deploy OpenStack as well? I think it does not but I am not 100 % certain about it. In a long term it would be good if the job deployed OpenStack as well because then we can do some basic checks that involve MCP.
There was a problem hiding this comment.
No no, this one only deploys OpenStack Lightspeed operator using the CRC ( so no full deployment of OpenStack control plane). for full OpenStack deployment + MCP integration testing, i think we'd need to add that to a seperate job or enhance this one - maybe we can keep track and have a seperate ticket for it
| - job: | ||
| name: lightspeed-operator-deployment-crc | ||
| parent: cifmw-base-crc | ||
| attempts: 1 |
There was a problem hiding this comment.
suggestion (blocking): I think you want to add openstack-k8s-operators-content-provider job as a dependency [1]. This job builds the operator and then provides it to the "child" jobs that depend on it. This allows you to test the operator from a content in a PR.
There was a problem hiding this comment.
Thanks for the pointer to this feature.. Yeah, I agree we should require a build from pr. I have make the change in ebf2560
| --- | ||
| # CI job for deploying OpenStack Lightspeed operator | ||
| - job: | ||
| name: lightspeed-operator-deployment-crc |
There was a problem hiding this comment.
suggestion (non-blocking): If I were working on this I would be using autohold to investigate the job from the inside.
The previous implementation had incorrect hook variable format and directly included tasks instead of using ci-framework's run_hook role. Changes: - Fixed hook format: Changed from string to proper list structure with name, type, and source fields as expected by run_hook role - Updated run playbook to use run_hook role instead of include_tasks - Added roles directive to make ci-framework roles available - Hook source points to install-openstack-lightspeed.yml in ci-framework/hooks/playbooks/ directory The run_hook role automatically resolves hook sources from ci-framework/hooks/playbooks/ and handles execution, logging, and artifact collection. Fixes: Job failure after 29m execution Related: OSPRH-33344
|
Build failed (check pipeline). Post ❌ lightspeed-operator-deployment-crc FAILURE in 20m 52s |
Added openstack-k8s-operators-content-provide as a job dependency to make sure that operator is built from pr changes before deployment. Without this the job wouold use the upstream catalogue image instead of testing the actual pr content. follows the pattern by openstack-operator https://github.com/openstack-k8s-operators/openstack-operator/blob/aeda4eda1c71ae34dabc5b458e1340ab755f41a4/zuul.d/jobs.yaml#L35 Related: OSPRH-33344
|
Unable to freeze job graph: Job lightspeed-operator-deployment-crc depends on openstack-k8s-operators-content-provider which was not run. |
The deployment job depends on OpenStack-k8s-operators-content-provider but it was not configured to run in the pipeline. this cased the error: 'Job depends on openstack-k8s-operators-content-provider which was not run' Added content-provider to the jobs list so it runs before deployment, building the operator from PR code and making it available for testing. Fixes: CONFIG_ERROR - dependency not satisfied Related: OSPRH-33344
|
Build failed (check pipeline). Post ❌ openstack-k8s-operators-content-provider FAILURE in 7m 04s |
3 participants
Creates lightspeed-operator-deployment-crc job that:
JIRA: OSPRH-33344